C2LC-442: Fix KeyboardShortcuts modal icon zooming issue in Firefox #237
C2LC-442: Fix KeyboardShortcuts modal icon zooming issue in Firefox #237chosww wants to merge 1 commit intocodelearncreate:develop-1.0from
Conversation
|
Nearly everything scales consistently with the changes here. Not sure if we want to fix this here, or in another pull, but there are a few remaining issues when "zoom text only" is checked:
See screenshot of points 3 and 4. Those are my notes from testing Firefox, I'll comment separately on other browsers in a few minutes. |
|
Everything scales appropriately and consistently in Chrome and Safari (in both OS X and the iOS simulator). The points I highlighted above work as I'd expect in other browsers, i.e.:
We should talk with Simon about whether we want to rework this issue to be very slightly larger, or break out the remaining fixes. I'd argue for the first, as the testing is very similar for all these issues. |
|
Yeah, I agree that we should rework this issue in a bit larger scale. Also, zooming out also causes some problems to more components than you have noted. |

See C2LC-442 for details.